Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] Global numpy shape flag #16335

Merged
merged 1 commit into from
Oct 10, 2019
Merged

[Numpy] Global numpy shape flag #16335

merged 1 commit into from
Oct 10, 2019

Conversation

stu1130
Copy link
Contributor

@stu1130 stu1130 commented Sep 30, 2019

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@stu1130 stu1130 force-pushed the numpy_shape branch 2 times, most recently from 200c4f7 to 652f650 Compare September 30, 2019 22:31
@haojin2 haojin2 requested a review from reminisce October 1, 2019 18:43
@haojin2 haojin2 added the Numpy label Oct 1, 2019
@stu1130 stu1130 changed the title [WIP][Numpy] Global numpy shape flag [Numpy] Global numpy shape flag Oct 1, 2019
@stu1130 stu1130 force-pushed the numpy_shape branch 6 times, most recently from b17d126 to e7e19cb Compare October 4, 2019 20:48
Copy link
Member

@eric-haibin-lin eric-haibin-lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we adding any test case for this?

@stu1130
Copy link
Contributor Author

stu1130 commented Oct 5, 2019

will reopen once test is added

@stu1130 stu1130 closed this Oct 5, 2019
@stu1130 stu1130 reopened this Oct 5, 2019
@stu1130 stu1130 changed the title [Numpy] Global numpy shape flag [WIP] [Numpy] Global numpy shape flag Oct 5, 2019
@stu1130 stu1130 changed the title [WIP] [Numpy] Global numpy shape flag [Numpy] Global numpy shape flag Oct 6, 2019
@stu1130
Copy link
Contributor Author

stu1130 commented Oct 6, 2019

@reminisce @eric-haibin-lin I added the test

ci/docker/runtime_functions.sh Outdated Show resolved Hide resolved
@stu1130
Copy link
Contributor Author

stu1130 commented Oct 7, 2019

@marcoabreu could you review again Thanks

@stu1130
Copy link
Contributor Author

stu1130 commented Oct 8, 2019

Hey @marcoabreu we really need this feature. Please review it. Thanks

@stu1130 stu1130 force-pushed the numpy_shape branch 4 times, most recently from ace3859 to 69bf35a Compare October 8, 2019 20:22
Copy link
Contributor

@marcoabreu marcoabreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roywei roywei merged commit 9dc0ab8 into apache:master Oct 10, 2019
aaronmarkham pushed a commit to aaronmarkham/incubator-mxnet that referenced this pull request Oct 16, 2019
@stu1130 stu1130 deleted the numpy_shape branch January 10, 2020 21:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants