This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stu1130
requested review from
anirudh2290 and
eric-haibin-lin
as code owners
September 30, 2019 18:54
stu1130
force-pushed
the
numpy_shape
branch
2 times, most recently
from
September 30, 2019 22:31
200c4f7
to
652f650
Compare
stu1130
changed the title
[WIP][Numpy] Global numpy shape flag
[Numpy] Global numpy shape flag
Oct 1, 2019
stu1130
force-pushed
the
numpy_shape
branch
6 times, most recently
from
October 4, 2019 20:48
b17d126
to
e7e19cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we adding any test case for this?
will reopen once test is added |
stu1130
changed the title
[Numpy] Global numpy shape flag
[WIP] [Numpy] Global numpy shape flag
Oct 5, 2019
stu1130
changed the title
[WIP] [Numpy] Global numpy shape flag
[Numpy] Global numpy shape flag
Oct 6, 2019
@reminisce @eric-haibin-lin I added the test |
reminisce
approved these changes
Oct 6, 2019
marcoabreu
suggested changes
Oct 6, 2019
@marcoabreu could you review again Thanks |
Hey @marcoabreu we really need this feature. Please review it. Thanks |
marcoabreu
reviewed
Oct 8, 2019
stu1130
force-pushed
the
numpy_shape
branch
4 times, most recently
from
October 8, 2019 20:22
ace3859
to
69bf35a
Compare
marcoabreu
approved these changes
Oct 8, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
roywei
approved these changes
Oct 10, 2019
aaronmarkham
pushed a commit
to aaronmarkham/incubator-mxnet
that referenced
this pull request
Oct 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments